Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade helm to 3.14.4 #129

Merged
merged 2 commits into from
Oct 10, 2024
Merged

upgrade helm to 3.14.4 #129

merged 2 commits into from
Oct 10, 2024

Conversation

xdu-opendoor
Copy link
Contributor

@xdu-opendoor xdu-opendoor commented Oct 10, 2024

tested by running make build

helm@3.14.4 fixes a template render bug with invoking tpl function (exists in helm@3.13.3)

the unfortunately starting from alpine/helm:3.15.x python@3.12 is installed, and build ends up with error complaining about imp module not found (dropped from python@3.11)

adding changes from #127

@xdu-opendoor
Copy link
Contributor Author

@Tang8330 can you help review this change?

Tang8330
Tang8330 previously approved these changes Oct 10, 2024
@Tang8330
Copy link
Collaborator

@xdu-opendoor - can you also upgrade Kubernetes? I had an outstanding PR to address it: https://github.com/Typositoire/concourse-helm3-resource/pull/127/files

@xdu-opendoor
Copy link
Contributor Author

xdu-opendoor commented Oct 10, 2024

@Tang8330 updated. I don't have preference on what VERSION to use. either 1.37.2 or 1.38.x would work for me.
lmk if you have any preference.

on a side note, is there a public repository you're publishing this image to? if you already did it i can simply pull from your public repo

@xdu-opendoor
Copy link
Contributor Author

@Tang8330 can you help me merge the PR? I'm getting permission error again

Only those with write access to this repository can merge pull requests.

@Tang8330 Tang8330 merged commit 57ce682 into Typositoire:main Oct 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants